Mark all deprecation lints in name resolution as deny-by-default and report-in-deps #143929

petrochenkov · 2025-07-14T15:03:16Z

This affects the next lints:

MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS - Tracking Issue for future-incompatibility lint macro_expanded_macro_exports_accessed_by_absolute_paths #144408
LEGACY_DERIVE_HELPERS - Tracking issue for deprecation lint legacy_derive_helpers #79202
PRIVATE_MACRO_USE - Tracking Issue for private_macro_use lint #120192
OUT_OF_SCOPE_MACRO_CALLS - Tracking Issue for future-incompatibility lint out_of_scope_macro_calls #144406

rustbot · 2025-07-14T15:03:22Z

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

petrochenkov · 2025-07-14T15:03:41Z

@bors try

Mark all deprecation lints in name resolution as deny-by-default and report-in-deps This affects the next lints: - `MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS` - no tracking issue - `LEGACY_DERIVE_HELPERS` - #79202 - `PRIVATE_MACRO_USE` - #120192 - `OUT_OF_SCOPE_MACRO_CALLS` - no tracking issue

bors · 2025-07-14T15:04:54Z

⌛ Trying commit 624f453 with merge dd2d87b...

bors · 2025-07-14T17:21:40Z

☀️ Try build successful - checks-actions
Build commit: dd2d87b (dd2d87b6cc31907ae305875eb6be399783dc0256)

petrochenkov · 2025-07-14T17:24:47Z

@craterbot check

craterbot · 2025-07-14T17:25:14Z

👌 Experiment pr-143929 created and queued.
🤖 Automatically detected try build dd2d87b
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-07-16T06:23:41Z

🚧 Experiment pr-143929 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-07-17T09:50:32Z

🎉 Experiment pr-143929 is completed!
📊 59 regressed and 7 fixed (664923 total)
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2025-07-17T14:42:27Z

Regressions:

LEGACY_DERIVE_HELPERS - 49
OUT_OF_SCOPE_MACRO_CALLS - 4
PRIVATE_MACRO_USE - 2
MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS - 0

From the LEGACY_DERIVE_HELPERS regressions, only gc-gcm-0.10.0 has some dependents on crates.io.
So I think it's fine to land this whole change, including the report-in-deps part for LEGACY_DERIVE_HELPERS.
I'll update it to fix the test failures.

lcnr · 2025-07-18T07:54:07Z

Why does MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS and OUT_OF_SCOPE_MACRO_CALLS not have any tracking issues? This seems suboptimal in case users encounter these lints and want to get further information/an easy way to get additional infos/help wrt to their project.

I think bumping these lints needs T-lang approval? Nominating

traviscross · 2025-07-23T00:49:58Z

For our notes, the docs on these lints:

traviscross · 2025-07-23T06:42:22Z

On review, this seems right and desirable to me (modulo that the tracking issues should be created). I propose...

@rfcbot fcp merge

rfcbot · 2025-07-23T06:42:24Z

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

bors · 2025-08-05T13:32:07Z

📌 Commit 33cb419 has been approved by lcnr

It is now in the queue for this repository.

Mark all deprecation lints in name resolution as deny-by-default and report-in-deps This affects the next lints: - `MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS` - rust-lang#144408 - `LEGACY_DERIVE_HELPERS` - rust-lang#79202 - `PRIVATE_MACRO_USE` - rust-lang#120192 - `OUT_OF_SCOPE_MACRO_CALLS` - rust-lang#144406

Rollup of 21 pull requests Successful merges: - #137831 (Tweak auto trait errors) - #138689 (add nvptx_target_feature) - #140267 (implement continue_ok and break_ok for ControlFlow) - #143679 (Preserve the .debug_gdb_scripts section) - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - #144133 (Stabilize const TypeId::of) - #144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144498 (Add --print target-spec-json-schema) - #144552 (Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144676 (Add documentation for unstable_feature_bound) - #144794 (Port `#[coroutine]` to the new attribute system) - #144835 (Anonymize binders in tail call sig) - #144836 (Change visibility of Args new function) - #144861 (Stabilize `panic_payload_as_str` feature) - #144910 (Add regression tests for seemingly fixed issues) - #144913 ([rustdoc] Fix wrong `i` tooltip icon) - #144917 (Enforce tail call type is related to body return type in borrowck) - #144924 (compiletest: add hint for when a ui test produces no errors) r? `@ghost` `@rustbot` modify labels: rollup

Mark all deprecation lints in name resolution as deny-by-default and report-in-deps This affects the next lints: - `MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS` - rust-lang#144408 - `LEGACY_DERIVE_HELPERS` - rust-lang#79202 - `PRIVATE_MACRO_USE` - rust-lang#120192 - `OUT_OF_SCOPE_MACRO_CALLS` - rust-lang#144406

Zalathar · 2025-08-07T03:57:57Z

Still trying to track down #144995 (comment)

@bors try jobs=dist-ohos-x86_64

rust-bors · 2025-08-07T03:58:01Z

⌛ Trying commit 33cb419 with merge 1ebf840…

To cancel the try build, run the command @bors try cancel.

Mark all deprecation lints in name resolution as deny-by-default and report-in-deps try-job: dist-ohos-x86_64

Mark all deprecation lints in name resolution as deny-by-default and report-in-deps This affects the next lints: - `MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS` - rust-lang#144408 - `LEGACY_DERIVE_HELPERS` - rust-lang#79202 - `PRIVATE_MACRO_USE` - rust-lang#120192 - `OUT_OF_SCOPE_MACRO_CALLS` - rust-lang#144406

rust-bors · 2025-08-07T05:25:22Z

☀️ Try build successful (CI)
Build commit: 1ebf840 (1ebf840e61858aec23ffca69ad431951c00b9c0b, parent: 6bcdcc73bd11568fd85f5a38b58e1eda054ad1cd)

Rollup of 20 pull requests Successful merges: - #137831 (Tweak auto trait errors) - #143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - #143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - #143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - #144133 (Stabilize const TypeId::of) - #144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - #144807 (Streamline config in bootstrap) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144903 (Rename `begin_panic_handler` to `panic_handler`) - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC) - #144974 (compiler-builtins subtree update) - #144997 (bump bootstrap compiler to 1.90 beta) - #145004 (Couple of minor cleanups) - #145009 (A couple small changes for rust-analyzer next-solver work) - #145014 (Revert "Preserve the .debug_gdb_scripts section") r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 19 pull requests Successful merges: - #137831 (Tweak auto trait errors) - #138689 (add nvptx_target_feature) - #140267 (implement continue_ok and break_ok for ControlFlow) - #143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - #143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - #143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - #144133 (Stabilize const TypeId::of) - #144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - #144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - #144650 (Additional tce tests) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144682 (Stabilize `strict_overflow_ops`) - #145026 (Update books) - #145033 (Reimplement `print_region` in `type_name.rs`.) - #145040 (rustc-dev-guide subtree update) Failed merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143929 - petrochenkov:depresolve, r=lcnr Mark all deprecation lints in name resolution as deny-by-default and report-in-deps This affects the next lints: - `MACRO_EXPANDED_MACRO_EXPORTS_ACCESSED_BY_ABSOLUTE_PATHS` - #144408 - `LEGACY_DERIVE_HELPERS` - #79202 - `PRIVATE_MACRO_USE` - #120192 - `OUT_OF_SCOPE_MACRO_CALLS` - #144406

Rollup of 19 pull requests Successful merges: - rust-lang/rust#137831 (Tweak auto trait errors) - rust-lang/rust#138689 (add nvptx_target_feature) - rust-lang/rust#140267 (implement continue_ok and break_ok for ControlFlow) - rust-lang/rust#143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - rust-lang/rust#143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - rust-lang/rust#143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - rust-lang/rust#143906 (Miri: non-deterministic floating point operations in `foreign_items`) - rust-lang/rust#143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - rust-lang/rust#144133 (Stabilize const TypeId::of) - rust-lang/rust#144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - rust-lang/rust#144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - rust-lang/rust#144473 (Address libunwind.a inconsistency issues in the bootstrap program) - rust-lang/rust#144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - rust-lang/rust#144650 (Additional tce tests) - rust-lang/rust#144659 (bootstrap: refactor mingw dist and fix gnullvm) - rust-lang/rust#144682 (Stabilize `strict_overflow_ops`) - rust-lang/rust#145026 (Update books) - rust-lang/rust#145033 (Reimplement `print_region` in `type_name.rs`.) - rust-lang/rust#145040 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#143857 (Port #[macro_export] to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 19 pull requests Successful merges: - rust-lang#137831 (Tweak auto trait errors) - rust-lang#138689 (add nvptx_target_feature) - rust-lang#140267 (implement continue_ok and break_ok for ControlFlow) - rust-lang#143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - rust-lang#143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - rust-lang#143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - rust-lang#143906 (Miri: non-deterministic floating point operations in `foreign_items`) - rust-lang#143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - rust-lang#144133 (Stabilize const TypeId::of) - rust-lang#144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - rust-lang#144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - rust-lang#144473 (Address libunwind.a inconsistency issues in the bootstrap program) - rust-lang#144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - rust-lang#144650 (Additional tce tests) - rust-lang#144659 (bootstrap: refactor mingw dist and fix gnullvm) - rust-lang#144682 (Stabilize `strict_overflow_ops`) - rust-lang#145026 (Update books) - rust-lang#145033 (Reimplement `print_region` in `type_name.rs`.) - rust-lang#145040 (rustc-dev-guide subtree update) Failed merges: - rust-lang#143857 (Port #[macro_export] to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 19 pull requests Successful merges: - rust-lang/rust#137831 (Tweak auto trait errors) - rust-lang/rust#138689 (add nvptx_target_feature) - rust-lang/rust#140267 (implement continue_ok and break_ok for ControlFlow) - rust-lang/rust#143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - rust-lang/rust#143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - rust-lang/rust#143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - rust-lang/rust#143906 (Miri: non-deterministic floating point operations in `foreign_items`) - rust-lang/rust#143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - rust-lang/rust#144133 (Stabilize const TypeId::of) - rust-lang/rust#144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - rust-lang/rust#144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - rust-lang/rust#144473 (Address libunwind.a inconsistency issues in the bootstrap program) - rust-lang/rust#144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - rust-lang/rust#144650 (Additional tce tests) - rust-lang/rust#144659 (bootstrap: refactor mingw dist and fix gnullvm) - rust-lang/rust#144682 (Stabilize `strict_overflow_ops`) - rust-lang/rust#145026 (Update books) - rust-lang/rust#145033 (Reimplement `print_region` in `type_name.rs`.) - rust-lang/rust#145040 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#143857 (Port #[macro_export] to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned lcnr Jul 14, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 14, 2025

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2025

This comment has been minimized.

Sign in to view

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 17, 2025

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025

lcnr added T-lang Relevant to the language team I-lang-nominated Nominated for discussion during a lang team meeting. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2025

petrochenkov added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2025

traviscross added the P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang label Jul 23, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025

Zalathar mentioned this pull request Aug 6, 2025

Rollup of 21 pull requests #144995

Closed

Zalathar mentioned this pull request Aug 7, 2025

Rollup of 21 pull requests #145034

Closed

Zalathar mentioned this pull request Aug 7, 2025

Rollup of 3 pull requests #145038

Closed

rust-bors bot added a commit that referenced this pull request Aug 7, 2025

Auto merge of #143929 - petrochenkov:depresolve, r=<try>

1ebf840

Mark all deprecation lints in name resolution as deny-by-default and report-in-deps try-job: dist-ohos-x86_64

Zalathar mentioned this pull request Aug 7, 2025

Rollup of 20 pull requests #145039

Closed

Zalathar mentioned this pull request Aug 7, 2025

Rollup of 19 pull requests #145043

Merged

bors merged commit 412eb76 into rust-lang:master Aug 7, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Aug 7, 2025

This was referenced Mar 23, 2025

Tracking issue for deprecation lint legacy_derive_helpers #79202

Open

Tracking Issue for private_macro_use lint #120192

Open

apiraino removed the to-announce Announce this issue on triage meeting label Aug 14, 2025

Mark all deprecation lints in name resolution as deny-by-default and report-in-deps #143929

Mark all deprecation lints in name resolution as deny-by-default and report-in-deps #143929

Uh oh!

Conversation

petrochenkov commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 14, 2025

Uh oh!

petrochenkov commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

This comment has been minimized.

bors commented Jul 14, 2025

Uh oh!

petrochenkov commented Jul 14, 2025

Uh oh!

craterbot commented Jul 14, 2025

Uh oh!

craterbot commented Jul 16, 2025

Uh oh!

craterbot commented Jul 17, 2025

Uh oh!

petrochenkov commented Jul 17, 2025

Uh oh!

lcnr commented Jul 18, 2025

Uh oh!

traviscross commented Jul 23, 2025

Uh oh!

traviscross commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Jul 23, 2025 • edited by joshtriplett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Aug 5, 2025

Uh oh!

Zalathar commented Aug 7, 2025

Uh oh!

rust-bors bot commented Aug 7, 2025

Uh oh!

rust-bors bot commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Jul 14, 2025 •

edited

Loading

traviscross commented Jul 23, 2025 •

edited

Loading

rfcbot commented Jul 23, 2025 •

edited by joshtriplett

Loading